Skip to content

Conversation

xavraz
Copy link
Contributor

@xavraz xavraz commented Oct 14, 2025

Creation of the zephyr/samples/net/openthread/shell/boards to support the MCXW7x boards components.

@xavraz xavraz force-pushed the feature/mcxw7x_shell branch from 828c2eb to d3ab123 Compare October 15, 2025 09:20
@zephyrbot zephyrbot requested a review from rlubos October 15, 2025 09:22
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix the commit title with samples: openthread: shell:, the current prefix suggests the change is related to the shell subsystem which isn't the case.
Also the DTS change seems unrelated to the sample changes, should go in a separate commit.

@xavraz xavraz force-pushed the feature/mcxw7x_shell branch from d3ab123 to 342d5e5 Compare October 15, 2025 12:17
@zephyrbot zephyrbot requested a review from rlubos October 15, 2025 12:19
@xavraz xavraz force-pushed the feature/mcxw7x_shell branch from 342d5e5 to 29139a4 Compare October 15, 2025 13:07
@xavraz
Copy link
Contributor Author

xavraz commented Oct 15, 2025

Please prefix the commit title with samples: openthread: shell:, the current prefix suggests the change is related to the shell subsystem which isn't the case. Also the DTS change seems unrelated to the sample changes, should go in a separate commit.

Done with another commit related to the RAM purpose.

@xavraz xavraz force-pushed the feature/mcxw7x_shell branch from 29139a4 to 559a9bd Compare October 15, 2025 13:22
rlubos
rlubos previously approved these changes Oct 15, 2025
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor compliance issues so please check the report.

@xavraz
Copy link
Contributor Author

xavraz commented Oct 15, 2025

There are some minor compliance issues so please check the report.

Launched "./scripts/ci/check_compliance.py" locally. Thanks

@zephyrbot zephyrbot requested a review from rlubos October 15, 2025 14:31
Creation of the zephyr/samples/net/openthread/shell/boards to support
the MCXW7x boards components.

Signed-off-by: Xavier Razavet <[email protected]>
To prevent a RAM overflow in the zephyr/samples/net/openthread/shell
application

Signed-off-by: Xavier Razavet <[email protected]>
@xavraz xavraz force-pushed the feature/mcxw7x_shell branch from fae7935 to db0de94 Compare October 15, 2025 14:36
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants